-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show tooltip on toggle custom size in FontSizePicker. #38985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
An existing feature does not function as intended
[Package] Components
/packages/components
labels
Feb 22, 2022
jasmussen
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mamaduka
approved these changes
Feb 22, 2022
Size Change: -3 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
Hey @ntsekouras , thank you for working on this! Would you mind opening a quick follow-up PR with a CHANGELOG entry referencing this fix? Thank you! |
ciampo
added
the
[Feature] UI Components
Impacts or related to the UI component system
label
Feb 23, 2022
ntsekouras
added a commit
that referenced
this pull request
Feb 23, 2022
ntsekouras
added a commit
that referenced
this pull request
Feb 23, 2022
No worries at all, and thank you again for the fix (and the follow-up PR) 🚀 |
cbravobernal
changed the title
[Components]: Show tooltip on toggle custom size in FontSizePicker
Show tooltip on toggle custom size in FontSizePicker.
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] UI Components
Impacts or related to the UI component system
[Package] Components
/packages/components
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #38931
Testing instructions
set custom size
toggle button in Font Size PickerNotes
Your theme should have custom font sizes support.